fix(runtime-dom): v-model breaks minlength validation #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unbyte
changed the title
yyx990803
requested changes
Aug 24, 2020
Contributor
|
Why not just compare the 2 values? The less involved the better performance. |
Contributor
Author
some biased performance tests misled me. it's my fault. 😭 |
Contributor
Author
|
🤐I have not processed a |
dsonet
suggested changes
Aug 25, 2020
| next !== prev || | ||
| (hostForcePatchProp && hostForcePatchProp(el, key)) | ||
| (hostForcePatchProp && hostForcePatchProp(el, key)) || | ||
| next !== prev |
Contributor
There was a problem hiding this comment.
Why do you change this order? Typically a compare operation would be lighter than a method invoke. It's reasonable to have the comparison ahead.
Contributor
Author
There was a problem hiding this comment.
yes you are right. I think I should learn more about javascript optimization.
https://jsben.ch/dSVTE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more detail: #1935 (comment)
close #1935